[
https://issues.apache.org/jira/browse/SHINDIG-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646059#action_12646059
]
Ian Boston commented on SHINDIG-560:
------------------------------------
I have some concerns about this patch,
Style: It does not conform to the style guide, (white space, full classnames in
the code not in imports etc)
Structure: It has introduced bindings to the JSON parsing libraries in the
DataHandler which I think is a mistake as these should be abstracted into the
Bean converter area to generate beans.
I see that there is some request scope loading and parsing of files which will
probably have issues with thread safety under load when an appserver is brought
on line in a active community... if its possible to have concurrent access, you
can bet it will happen.
So, at the moment, I am not inclined to apply this as it stands, but others my
have different views.
> Add support for @supportedFields
> --------------------------------
>
> Key: SHINDIG-560
> URL: https://issues.apache.org/jira/browse/SHINDIG-560
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Priority: Blocker
> Attachments: fix-560-bug.patch, shindigpatch-560.patch
>
>
> We need to add support for the @supportedFields query on each handler. (ie
> people/@supportedFields, activities/@supportedFields)
> Maybe a guice binding to a set of strings or something similar would make
> this work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
