[
https://issues.apache.org/jira/browse/SHINDIG-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Winer updated SHINDIG-560:
-------------------------------
Attachment: supportedFields.patch
Attached patch that redoes this all in terms of a generic ContainerConfig, and
moved it up to a generic implementation in DataServiceServlet instead of
pushing into the DataRequestHandlers. The patch does not itself delete the
ContainerConf/JsonContainerConf classes, but they're now unused and can be
deleted.
The patch would be much simpler with Kevin's ContainerConfig changes (in
particular, because it Map-ifies and List-ifies out of the gate), but I don't
think it makes sense to push Kevin's work onto the 1.0 branch.
The major issue with the patch is that there is no portable way to get the
container from a RESTful request, so no way to pick the right container out of
the config. This patch "solves" that problem by providing a protected hook
method that can be overridden, but a portable technique
(SecurityToken.getContainer(), perhaps?) would be far better.
> Add support for @supportedFields
> --------------------------------
>
> Key: SHINDIG-560
> URL: https://issues.apache.org/jira/browse/SHINDIG-560
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Priority: Blocker
> Fix For: trunk, 1.0.x-incubating
>
> Attachments: ContainerConf.java, fix-560-bug.patch,
> JsonContainerConf.java, SHINDIG-560.patch, shindigpatch-560.patch,
> supportedFields.patch
>
>
> We need to add support for the @supportedFields query on each handler. (ie
> people/@supportedFields, activities/@supportedFields)
> Maybe a guice binding to a set of strings or something similar would make
> this work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
