[
https://issues.apache.org/jira/browse/SHINDIG-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666366#action_12666366
]
Kevin Brown commented on SHINDIG-560:
-------------------------------------
Sorry for chiming in late on this one.
This patch doesn't really make any sense:
1. It depends explicitly on constructing JsonContainerConfig in the (oddly
named) ContainerConf wrapper. This makes dependency injection impossible,
forcing you to completely re-implement JsonContainerConf if you want so support
this. Particularly problematic, it only supports one container -- the default.
2. It's re-implementing what ContainerConfig itself is already doing. Querying
the nested fields can already be done directly by calling
ContainerConfig#getJsonObject(container, "/path/to/field/") (soon to be
replaced by ${path.to.field}).
3. There's no documentation indicating what ContainerConf is or what it should
be used for.
4. @Inject on a no arg ctor?
All in all, it's a serious WTF.
> Add support for @supportedFields
> --------------------------------
>
> Key: SHINDIG-560
> URL: https://issues.apache.org/jira/browse/SHINDIG-560
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Priority: Blocker
> Fix For: trunk, 1.0.x-incubating
>
> Attachments: ContainerConf.java, fix-560-bug.patch,
> JsonContainerConf.java, SHINDIG-560.patch, shindigpatch-560.patch
>
>
> We need to add support for the @supportedFields query on each handler. (ie
> people/@supportedFields, activities/@supportedFields)
> Maybe a guice binding to a set of strings or something similar would make
> this work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
