[
https://issues.apache.org/jira/browse/SHINDIG-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730840#action_12730840
]
Johan Euphrosine commented on SHINDIG-1112:
-------------------------------------------
It seems that trunk has the same issue:
io.js:350
headers: gadgets.io.encodeValues(headers, false),
# would produce: key1=value1&key2=value2
ProxyBase.php:78
if (isset($_POST['headers'])) {
$request->setHeaders($_POST['headers']);
}
RemoteContentRequest.php:234
public function setHeaders($headers) {
$this->headers = $headers;
}
# headers still key1=value1&key2=value2
RemoteContentRequest.php:240
public function getHeader($headerName) {
$headers = explode("\n", $this->headers);
foreach ($headers as $header) {
$key = explode(":", $header, 2);
if (strtolower(trim($key[0])) == strtolower($headerName)) return
trim($key[1]);
}
return null;
}
# getHeader explode headers as if they were key1: value1\nkey2=value2
# but they are still key1=value1&key2=value2
Do you want me to write a test case that reproduce this issue on trunk ?
> SignedFetcher doesn't forward gadgets.io.RequestParameters.HEADERS
> ------------------------------------------------------------------
>
> Key: SHINDIG-1112
> URL: https://issues.apache.org/jira/browse/SHINDIG-1112
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: 1.0
> Reporter: Johan Euphrosine
> Assignee: Chris Chabot
> Fix For: 1.0
>
>
> When a request a signed, shindig doesn't forwarder
> gadgets.io.RequestParameters.HEADERS,
> Because:
> _POST['headers'] are www-form-encoded, key1=value1&key2=value2
> And:
> BasicRemoteContentFetcher.php expects key1: value1\nkey2: value2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
