[
https://issues.apache.org/jira/browse/SHINDIG-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730885#action_12730885
]
Chris Chabot commented on SHINDIG-1112:
---------------------------------------
Hey Johan,
We can't accept copy right protected contributions (from ProxyBaseTest.php):
/**
* Copyright (c) 2009, Johan Euphrosine <[email protected]>.
*/
Also as you've noticed in the rest of the source I'm sure, we don't do 'created
by <user>' marks in files either, it goes against 'The Apache Way' (by claiming
a source file you discourage contributions by others), and it also opens up a
can of worms about "When to add your name to a file?", at 2 lines, at 20? only
if it's a major change? and what if you end up with 100 contributors? So the
ASF has the rule that it's better not to do that.
Oh and a small note on the style, we always start php files with <?php (<?
short tags isnt supported everywhere), and never end with ?>, the ?>'s tend to
generate undesiriable EOL's in the output of pages and that's prevented by just
completely omitting them
> SignedFetcher doesn't forward gadgets.io.RequestParameters.HEADERS
> ------------------------------------------------------------------
>
> Key: SHINDIG-1112
> URL: https://issues.apache.org/jira/browse/SHINDIG-1112
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: 1.0
> Reporter: Johan Euphrosine
> Assignee: Chris Chabot
> Fix For: 1.0
>
> Attachments: proxy-base-convert-post-headers.patch
>
>
> When a request a signed, shindig doesn't forwarder
> gadgets.io.RequestParameters.HEADERS,
> Because:
> _POST['headers'] are www-form-encoded, key1=value1&key2=value2
> And:
> BasicRemoteContentFetcher.php expects key1: value1\nkey2: value2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
