On 8/2/2017 5:57 AM, Tom Eastep wrote: > On 07/30/2017 06:25 AM, Matt Darfeuille wrote: >> Here's my take on the release script!? > > Hi Matt, > > I used your script to release 5.1.5.2 :-) > > A couple of comments: > > a) The script doesn't allow the tag to be different from the release. > Currently, the tag for a minor release (Shorewall w.x.y) is w.x.y-base; > that is required to make it distinct from the path name for that > release which is simply w.x.y. Changing the convention for naming paths > would require a version-dependent change to the build script which knows > how to determine the appropriate path name for a given release. >
Sorry but I don't understand the issue! I did some testing and didn't incounter this problem (what command dit you use?). > b) The script assumes that the correct path is checked out in both the > code and release repositories. If a different path is checked out, the > tag gets assigned to the wrong path. > > c) The script doesn't push the path to 'origin' with tags. I also push > to a 'Server' repository which is hosted at www.shorewall.org. > How do I send the patches (as usual) or do you want the corrected script? -Matt -- Matt Darfeuille ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
