On 8/9/2017 10:45 PM, Tom Eastep wrote:
> On 08/09/2017 01:34 PM, Tom Eastep wrote:
>> On 08/03/2017 04:45 AM, Matt Darfeuille wrote:
>>> Signed-off-by: Matt Darfeuille <matd...@gmail.com>
>>> ---
>>>  build/release | 18 ++++++++++++++++++
>>>  1 file changed, 18 insertions(+)
>>>
>>
>> Hi Matt,
>>
>> When I executed
>>
>>      release -pu 5.1.6-Beta2
>>
>> I got:
>>
>> Pushing tag 5.1.6-Beta2 from /home/teastep/shorewall/trunk/.git...
>> fatal: 'refs/tags/5.1.6-Beta2' does not appear to be a git repository
>> fatal: Could not read from remote repository.
>>
>> Please make sure you have the correct access rights
>> and the repository exists.
>>    ERROR: Failed to push tag 5.1.6-Beta2 from
>> /home/teastep/shorewall/trunk/.git.
>> teastep@debianvm:~/shorewall/build/5.1.6$
>>
> 
> I would have expected the push command to be something like
> 
>       git --git-dir=${1}/.git push --tags origin $BRANCH
> 
> Where $BRANCH is $BASEVERSION if that branch exists, otherwise 'master'.
> 

Tom,

the '--tags' option will push all tags which is unnecessary given that
the script knows what tags should be pushed.
My suggestion would rather be the following:

... push --followtags origin HEAD

From:

https://git-scm.com/docs/git-push

"--follow-tags
Push all the refs that would be pushed without this option, and also
push annotated tags in refs/tags that are missing from the remote but
are pointing at commit-ish that are reachable from the refs being pushed."

"git push origin HEAD
A handy way to push the current branch to the same name on the remote."


You also pushe to sourceforge; won't a push script be better?

the push script would do the following:

1)  Push to shorewall.org.
2)  Push to sourceforge.
3)  Anything else?

I don't have the time to do it right now but I could send it later, In
any case I will fix the release script!

-Matt
-- 
Matt Darfeuille

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-devel mailing list
Shorewall-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to