On 08/02/2017 11:02 AM, Matt Darfeuille wrote: > On 8/2/2017 5:57 AM, Tom Eastep wrote: >> On 07/30/2017 06:25 AM, Matt Darfeuille wrote: >>> Here's my take on the release script!? >> >> Hi Matt, >> >> I used your script to release 5.1.5.2 :-) >> >> A couple of comments: >> >> a) The script doesn't allow the tag to be different from the release. >> Currently, the tag for a minor release (Shorewall w.x.y) is w.x.y-base; >> that is required to make it distinct from the path name for that >> release which is simply w.x.y. Changing the convention for naming paths >> would require a version-dependent change to the build script which knows >> how to determine the appropriate path name for a given release. >> > > Sorry but I don't understand the issue! > > I did some testing and didn't encounter this problem (what command dit > you use?).
release -u 5.1.5-base
I believe that this command passes "5.1.5-base" to the upload script
which is expecting "5.1.5".
>
>> b) The script assumes that the correct path is checked out in both the
>> code and release repositories. If a different path is checked out, the
>> tag gets assigned to the wrong path.
>>
>> c) The script doesn't push the path to 'origin' with tags. I also push
>> to a 'Server' repository which is hosted at www.shorewall.org.
>>
>
> How do I send the patches (as usual) or do you want the corrected script?
Patches are preferred -- I applied your initial patch to my repository
and have subsequently changed the permissions so that the script is
executable.
Thanks,
-Tom
--
Tom Eastep \ Q: What do you get when you cross a mobster with
Shoreline, \ an international standard?
Washington, USA \ A: Someone who makes you an offer you can't
http://shorewall.org \ understand
\_______________________________________________
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
