Hi, thanks a lot for your patches and issue reports (and patience)!
Sorry for the delay, I wanted to look at your patches a lot sooner, but real life kept me pretty busy. I've merged your changes (split into a few commits) and with some added commit messages etc. They all look correct (and I fixed a few compiler warnings arising due to added -Wall). The stdout/stderr stuff is OK for PulseView too (but we avoid stdout completely in e.g. sigrok-cli since the actual data output of that tool can be piped into other tools/scripts, so all non-data output there goes to stderr). The 'extern "C"' seem unneeded indeed since the system headers, and glib, and libsigrok/libsigrokdecode all use it already anyway. Feel free to send patches as "git format-patch"-generated files btw., that way your name properly appears in the git history and the patches also come with a commit message already and so on. Cheers, Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
