On Sun, Oct 16, 2016 at 06:25:22PM +0200, Gerhard Sittig wrote:
> The version text length check fails for git setups that use more digits
> in abbreviated hashes, as is recommended by e.g. the Linux kernel project.
> 
> Raise the upper limit for acceptable version strings, and add comments
> on how the limits were determined.  The test still might fail in setups
> of slightly different configuration, but now it's easier to see why the
> test failed, and how to adjust the test.
> 
> Signed-off-by: Gerhard Sittig <gerhard.sit...@gmx.net>

Merged with minimal changes, thanks!


> + * - A version text consists of three parts (major, minor, build),

Replaced "build" with "micro" here (and below).


> +     const size_t version_text_length_min = 5;
> +     const size_t version_text_length_max = 2 + 1 + 2 + 1 + 2 + 5 + 12;

And these two variables have slightly shorter names now.


Cheers, Uwe.
-- 
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to