Unfortunately, it isn't quite clear to me whether the question been addressed.


I'm not too concerned whether the decode_end() methods are called in PD stack 
order.  The check-in appears to handle that nicely.


The issue is whether a put() called by a lower-level PD during its decode_end() 
will result a higher layer PD having its decode() method called (of course, the 
decoded_end() method will be called soon afterwards).  I'm just looking for 
confirmation.


-Chris


________________________________
From: Gerhard Sittig <gerhard.sit...@gmx.net>
Sent: Sunday, October 16, 2016 10:53 PM
To: sigrok-devel@lists.sourceforge.net
Subject: Re: [sigrok-devel] [PATCH 9201/9201] decode session: add optional 
decode_end() PD method and send_eof() session call

On Sun, Oct 16, 2016 at 19:14 +0000, Chris Dreher wrote:
>
> I appreciate this being worked on.

Notice that we are talking about "flush" here, not "late
manipulation".  For file header updates as samples get appended,
there already is an undisputed approach (output modules).


> There is one scenario I am wondering whether it is handled.  I
> am not familiar enough with libsigrokdecode's code to know.
> The question is when a lower-level PD has its decode_end()
> called and that PD flushes data with calls to put(), will the
> next higher-level PD have its decode() called before its own
> decode_end() is called?

The suggested send_eof() routine is modelled after the already
existing send() routine, so that the decode_end() methods will
get invoked in the very order in which currently decode() methods
get invoked.  Which translates to "in most appropriate ways" for
stacked decoders. :)  Lower layers first, pushing remaining data
if necessary, upper layers then, and all of it before closing the
output.

The commit messages tried to hint towards this ("Execution order
copes with decoder stacks.").  How to improve that message?

Shall I provide a doc update with the code submission?  Though I
could not find any doc section with 'grep -rw decode', did I miss
it due to markup, perhaps?


virtually yours
Gerhard Sittig
--
     If you don't understand or are scared by any of the above
             ask your parents or an adult to help you.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Slashdot: News for nerds, stuff that matters<http://sdm.link/slashdot>
sdm.link
Slashdot: News for nerds, stuff that matters. Timely news source for technology 
related news with a heavy slant towards Linux and Open Source issues.


_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
sigrok-devel Info Page - 
SourceForge<https://lists.sourceforge.net/lists/listinfo/sigrok-devel>
lists.sourceforge.net
To see the collection of prior postings to the list, visit the sigrok-devel 
Archives. Using sigrok-devel: To post a message to all the list members ...


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to