Fix the udev rules used to setup the USB device permissions so that they
work with all udev versions.

The first bug is triggered by earlier udev versions when trying to detect
the USB subsystem.

The second problem is that the TAG method does work only with udev from
systemd and not with earlier udev versions.

This patch has been successfully tested with udev from systemd (recent
versions) as well as ancient udev versions that were not shipped with
systemd (e.g. version 182 from kernel.org).

Signed-off-by: Guido Trentalancia <gu...@trentalancia.com>
---

diff -pru libsigrok-git-20102018/contrib/60-libsigrok.rules 
libsigrok-git-20102018-fix-udev-rules/contrib/60-libsigrok.rules
--- libsigrok-git-20102018/contrib/60-libsigrok.rules   2018-10-20 
13:12:30.838966966 +0200
+++ libsigrok-git-20102018-fix-udev-rules/contrib/60-libsigrok.rules    
2018-10-21 00:36:38.494626234 +0200
@@ -33,7 +33,11 @@
 #
 
 ACTION!="add|change", GOTO="libsigrok_rules_end"
-SUBSYSTEM!="usb|usbmisc|usb_device", GOTO="libsigrok_rules_end"
+SUBSYSTEMS=="usb", GOTO="libsigrok_rules_begin"
+
+GOTO="libsigrok_rules_end"
+
+LABEL="libsigrok_rules_begin"
 
 # Agilent USBTMC-connected devices
 # 34405A
diff -pru libsigrok-git-20102018/contrib/61-libsigrok-uaccess.rules 
libsigrok-git-20102018-fix-udev-rules/contrib/61-libsigrok-uaccess.rules
--- libsigrok-git-20102018/contrib/61-libsigrok-uaccess.rules   2018-10-20 
13:12:30.839966966 +0200
+++ libsigrok-git-20102018-fix-udev-rules/contrib/61-libsigrok-uaccess.rules    
2018-10-21 00:37:44.636625963 +0200
@@ -27,6 +27,6 @@
 
 ACTION!="add|change", GOTO="libsigrok_rules_uaccess_end"
 
-ENV{ID_SIGROK}=="1", TAG+="uaccess"
+ENV{ID_SIGROK}=="1", MODE="0666"
 
 LABEL="libsigrok_rules_uaccess_end"


_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to