On Thu, 08/11/2018 at 17.11 +0000, Brüns, Stefan wrote: > On Sonntag, 21. Oktober 2018 20:26:20 CET Guido Trentalancia wrote: > > As already explained, the TAG method does not work with all udev > > versions!! > > The very first udev version imported into the systemd repository > already > supports TAG - that happened 2012-04-04.
Udev exists since before systemd was first released. So, I have to repeat once again: "As already explained, the TAG method does not work with all udev versions!!" > > If you want sigrok to work consistently and flawlessly with all > > udev > > versions, you have to use the patch that I posted! > > As you don't provide any details nobody can tell to which udev > "replacement" > you are referring to. I am not talking about a udev "replacement". I am talking about the original udev. The details are clearly and detailedly provided in the patch description and in the previous messages. Once again, I have to repeat (for the last time, hopefully): "This patch has been successfully tested with udev from systemd (recent versions) as well as ancient udev versions that were not shipped with systemd (e.g. version 182 from kernel.org)." > The majority of distributions use the regular udev maintained in the > systemd > repository. Your patch breaks permissions for anyone relying on the > uaccess > scheme. The patch provides support for all udev versions ever released and not just the latest ones (i.e. those shipped with systemd). > > Least but not last the GROUP setting is too distribution-specific, > > for > > example, "plugdev" I think exists only in Debian, so there is no > > point in > > distributing such file. > > It is distributed in the sources. Distributors can pick the rules > file they > consider appropriate. They can also patch a different group into the > file. > > It also serves as an example for anyone who wants to grant access > permissions > based on group membership. > > So full NAK for this patch. This patch is not particularly important... It is recommended though, for full support across all udev versions. Regards, Guido _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
