On Sun, 2021-03-14 at 18:58 +0100, Helge Kruse wrote:
>
> Am 14.03.2021 um 12:50 schrieb Kevin Grant:
> >
> > I submitted a PR for the sigrok-utils LA2016 firmware
> > extraction script
> >
> > https://github.com/sigrokproject/sigrok-util/pull/6/files
> > <https://github.com/sigrokproject/sigrok-util/pull/6/files>
> >
> > It works for me but if someone else could verify then it
> > would help get it accepted.
> >
> The script for extraction of the MCU firmware and FPGA
> bitstream files for LA-2016 from the KingstVIS works perfectly.
> The MCU firmware files (*.fw) are binary identical to the files
> from the previous version. Also the FPGA bitstream for LA-2016
> is identical.
Have trouble reading those commits and their messages. Can't tell
_what_ is "fixed" there, what the problem was, what the change
is, and whether the problem will reappear at any time for
whatever the cause might have been since it's uncertain.
You say that the set of extracted files is identical to before
and after that change. What am I missing?
Try to create the commit messages from the future reader's
perspective. Don't assume that the reader has the exact context
or level of detail that you may have while digging into this.
Help readers get to where you currently are, they aren't there
yet. They don't know what may be obvious to you, they cannot see
what's local to you.
> Additionally, the script extracts bitstreams for other Kingst
> LA devices (1016, 5016, 5032). This extends the supported
> devices of sigrok. The kingst driver will detect the necessary
> files and download them to the device.
As far as I can see the driver exclusively supports a single
device. Extracting more firmware files does not change its
behaviour. So the extraction utility change neither changes nor
extends any support to other devices. Am I missing something? Are
you referring to some unspecified external implementation?
How does the above mentioned PR relate to other PRs? Is it
similar, or identical, or different and how so? Can you
coordinate these changes with other submitters, or at least
communicate when there is a duplication or what its motivation
may be? Tell when there are dependencies on other PRs? Ideally
combine them and not duplicate them?
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
