Nice one - thanks.
Just checked that in too. SVN 45.

Olivier.

On 9/21/06, F. Tarek Rogers <[EMAIL PROTECTED] > wrote:

Thanks - while your checking stuff in - found a segfault when using -nd and handling an unexpected message.

process_unexpected was returning 'true' when -nd is used, which attempts to continue progressing the call despite the unexpected message, which causes a segfault in incoming_message on the next receive.  If false is returned, -nd still bypasses the abortCall() stuff, but treats the call as a failed call, and doesn't crash.

Here's the diff against the new 09-21 build:

diff -bruN call.cpp.orig call.cpp
--- call.cpp.orig       2006-09-21 16:56:05.091894465 -0400
+++ call.cpp    2006-09-21 16:56:10.995928261 -0400
@@ -1495,7 +1495,7 @@
   return (abortCall());
   } else {
     // Do not abort call nor send anything in reply if default behavior is disabled
-    return true;
+    return false;
   }
}


> Checked-in.
> http://sipp.sourceforge.net/snapshots/sipp.2006-09-21.tar.gz
>
> Thanks, that was fast!
> Olivier.
>



--
HP OpenCall Software
http://www.hp.com/go/opencall/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Sipp-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sipp-users

Reply via email to