On Tue, 2009-10-06 at 23:38 -0400, Dale Worley wrote: > I'm cleaning up some minor debris from splitting sipXrls, sipXpark, and > sipXpresence as separate components, and I ran across a few places where > sipXvxml was still listed as a component, despite having been deleted a > week or two ago. > > It struck me that a better solution than the current situation of > maintaining several lists of the components of sipXecs would be to have > a single program or value that lists them all. > > This led me to define "sipxecs-components", which is a script that you > run to get a list of all the components of sipXecs. This requires > changing half a dozen files a little bit, but after you get it set up, > $( sipxecs-components ) will give you the list of components based on > the top-level configure.ac, which has to be right in order for the build > to work. > > I've attached the diffs for this change so you can have a look at it. > Any comments?
Your change only shows one place where the list is used... shouldn't you also change the others (and what were they)? I think that there's an ordering problem here - you have the sipxecs-components script being installed by the sipxecs rpm, but used by a script in the sipxportlib rpm (upon which sipxecs depends). >From a user perspective, I'd rather see this list be available as an output of the existing sipx-config script (sipx-config --components). That could be done similarly to what you've already done by having the top level Makefile.am have a rule to create a file COMPONENTS that just has the list of components in it, and then in the rule for building sipx-config, incorporate that list in the localization step. This is similar to what is already done for incorporating the build stamp information. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
