On Wed, 2009-10-07 at 07:56 -0400, Scott Lawrence wrote:
> Your change only shows one place where the list is used... shouldn't you
> also change the others (and what were they)?
I will, but I wanted to discuss the approach before tweaking all the
places it needs to be used.
> I think that there's an ordering problem here - you have the
> sipxecs-components script being installed by the sipxecs rpm, but used
> by a script in the sipxportlib rpm (upon which sipxecs depends).
Actually, the ordering problem is stranger than that: The list of
components is used in sipx-config, whose source is
sipXportLib/bin/sipx-config. That script seems to have nothing to do
with sipXportLib at all -- I suspect that it is there simply because
sipXportLib is the first component, and several components depend on
sipx-config. ... I see references in:
sipXbridge/sipxrelay.sh.in
sipXbridge/sipxbridge.sh.in
sipXcommserverLib/bin/ssl-cert/gen-ssl-keys.sh.in
sipXconfig/web/bin/sipxconfig.sh.in
sipXivr/bin/sipxivr.sh.in
sipXopenfire/sipxopenfire.sh.in
sipXpage/bin/sipxpage.sh.in
sipXrest/sipxrest.sh.in
sipXtools/src/sipviewer/bin/sipviewer.in
I'm thinking that there should be a component for "tools that all the
real components depend on". OTOH, I don't think that any of these
scripts runs during the build, so there is no need to build sipx-config
before building anything else, as long as we do it before running these
components.
OK, now a third opinion: sipx-config does two very distinct things:
"sipx-config --java", which tells about the platform's Java
configuration, and "sipx-config --version", which gives the versions of
all the sipXecs components. The first is a tool used by many
components, the second is a tool that describes all the components.
Perhaps the two functions should be separated?
(Ugh, and sipx-config's usage message describes a "--javabin" switch,
but the logic to process that switch was deleted in rev. 11649.)
> From a user perspective, I'd rather see this list be available as an
> output of the existing sipx-config script (sipx-config --components).
Yes, that would be easy to do, make sense, and avoid the proliferation
of scripts.
Dale
_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/
