On Mon, 2010-04-19 at 15:41 -0700, George Niculae wrote:
>
> --- On Mon, 4/12/10, Scott Lawrence <[email protected]> wrote:
> >
> > >
> > > IMO we shouldn't enforce any max length on these
> > fields, but only
> > > validate it's a valid value (that's it, an int value).
> >
> >
> > Not that it's an int... that it's a sequence of dial string
> > characters.
> >
> > '[0-9*#]+'
>
> Checked the code and right now we are handling extensions as integers
> - (first, last and next extensions are defined as integers in
> extension_pool table). Since is too late to make such a change in this
> release I propose to keep extensions as integers and to track this
> change in a separate JIRA issue (unless we agree that this one is
> something critical and we really have to push it in the current
> release).
>
> Please comment.
I don't think it's critical, but everyone should note this for future
code:
Just because phone numbers consist of digits, that does not make
them integers or any other kind of numbers. They are strings.
_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/
