[ 
https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662354#action_12662354
 ] 

Michael Dürig commented on SLING-549:
-------------------------------------

> 1 Is there a reason to have two projects instead of one single project ? 

Separation of the Scala and the Java parts. Having mixed Scala and Java sources 
in a single project does not work well with the maven-scala-plugin and with the 
Scala Eclipse plugin ATM. We might fix this when the tools catch up.


> 2 Is there a reason to exclude the imports of Sling packages in the 
> ScriptEngine project ? 

You mean 
!org.apache.tools.ant.*,!org.apache.sling.jcr.api.*,!org.apache.sling.scripting.api.*
 ?
I could not get the bundle to install without excluding these: 

!! org.apache.sling.jcr.api,version=2.0.3.incubator-SNAPSHOT from -- Cannot be 
resolved

and so on.


3 and 4 are inherited from when I took over the GSoC code base. Should be easy 
to fix.


> Scala interpreter should use the current ClassLoader instead of rebuilding 
> its own classpath
> --------------------------------------------------------------------------------------------
>
>                 Key: SLING-549
>                 URL: https://issues.apache.org/jira/browse/SLING-549
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-549.patch
>
>
> As the code at [1] demonstrates, the scala interpreter rebuilds its own 
> classpath from the current JVM classpath and user-supplied additions.
> We should find a way for it to use the current classloader instead.
> Note that the almost same test [2] works when run with "mvn test" without 
> setting the classpath explicitly, probably because in this case the JVM 
> classpath includes the scala jars.
> [1] 
> http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java
> [2] 
> http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to