Sebastien Roy wrote: > Sebastien Roy wrote: >> Here's the webrev: >> >> http://cr.opensolaris.org/~seb/webrev-smf/ > > I've updated the webrev at the URL above with comments from Alan, Meem, > and Liane. I've re-tested, and the updates are copasetic. Please take a > second look. >
Looks fine to me. Just a couple nits for net_include.sh 585 - comments should probably mention net-nwam as another consumer 609 - use network/datalink-management:default for consistency 626 - I'd prefer break from if $? -eq 0 and examine $state outside of the loop once. -tony
