Peter Memishian wrote:
>  > Here's the webrev:
>  > 
>  > http://cr.opensolaris.org/~seb/webrev-smf/
> 
> As workarounds go, seems good.  The formatting of 90-92 would be slightly
> preferable as:
>                         state=`svcprop -p restarter/state \
>                           datalink-management:default 2>/dev/null`
> 
> Also, the paranoid might prefer "network/datalink-management" to
> datalink-management.

Yes, I've changed that.

> 
> Are you confident that 5 seconds is enough?

Yes.  In 10 reconfigure boot test cycles, it has never taken more than 
1.x seconds to come online (thanks to handy "echo" debugging output I had 
previously placed in there).  I'll gladly increase the timeout to 
whatever folks think is appropriate since I know it will never take more 
than 2 seconds. :-)  It sounds like Liane is suggesting 30, so I'll do that.

-Seb

Reply via email to