Peter Memishian wrote: > > Here's the webrev: > > > > http://cr.opensolaris.org/~seb/webrev-smf/ > > As workarounds go, seems good. The formatting of 90-92 would be slightly > preferable as: > state=`svcprop -p restarter/state \ > datalink-management:default 2>/dev/null` > > Also, the paranoid might prefer "network/datalink-management" to > datalink-management.
We do try to encourage not taking advantage of the svc* commands fnmatch capabilities in scripts. > > Are you confident that 5 seconds is enough? Ditto on that question. I'd be tempted to give it more time. (As a data point, the network/physical:[nwam|default] start method timeouts are both 600 seconds. Anything under a minute would probably not be out of the realm of reasonable. I'd probably choose something between 10 and 30 seconds, but that's only a few seconds of consideration better than a wild guess.) Also, before exiting on line 100, it'd be nice to print out a message about what went wrong so that a system that followed this codepath has something helpful in the logfile. liane
