Steve Peng writes:
>
> The full nightly build was built successfully and testings look good as
> well. I have posted the new incremental webrev under
>
> http://cr.opensolaris.org/~stevep/6351623-2
>
> The previous one has been moved under 6351623-1. Please take a look at
> and if you can get back to me with any new comment
> by cob Wed then that will great.
>
> Thanks
>
> Steve
Hi Steve,
Just a couple of comments below.
tom
usr/src/cmd/svc/configd/backend.c:
lines 824-825:
It is possible that the allocation for finalpath can
succeed and the one for tmppath can fail. If this happens,
the memory for finalpath will not be freed.
Actually, it looks as if finalpath and tmppath are never
freed in backend_create_backup_locked().
line 1134...
tmppath is not freed in backend_switch_copy()
usr/src/cmd/svc/configd/client.c:
usr/src/cmd/svc/configd/configd.h:
usr/src/cmd/svc/milestone/manifest-import:
usr/src/cmd/svc/svcadm/svcadm.c:
usr/src/common/svc/repcache_protocol.h:
usr/src/lib/libscf/common/lowlevel.c:
usr/src/lib/libscf/common/mapfile-vers:
usr/src/lib/libscf/inc/libscf_priv.h:
OK
