David, Tom This should be a quick review. A new incremental webrev has been posted under
http://cr.opensolaris.org/~stevep/6351623-inc Please take a look at and I will proceed with rti if everything looks fine. Thanks Steve David Bustos wrote: > Quoth Steve Peng on Mon, Feb 11, 2008 at 09:50:27AM -0700: > >> A new full webrev has been posted under >> >> http://cr.opensolaris.org/~stevep/6351623 (6351623 Initial >> manifest-import is slow) >> > > common/svc/repcache_protocol.h > 363: The switch operation no longer accepts src & dst arguments, so > please fix this comment. > Fixed. > cmd/svc/configd/client.c > 2008: According to the comment before backend_switch() in backend.c, > this function can also fail with _BACKEND_READONLY and _TRUNCATED. > Added. > cmd/svc/configd/backend.c > 767: If this error occurs with src = /etc/svc/volatile/fast_repository.db, > then we can tell the user that the switch-back failed. But if it > happens with src = /etc/svc/repository.db, then we won't know > whether backup failed or whether original switch failed. I think > you should at least include dst in the error message, but it might > be better to return an error code so that the caller can issue an > error message which explains what went wrong and what the user > should do. This should be pretty rare, though, so I think it would > be ok to do it under a bug later. > I will file a bug later. > 838: Since this (goto out) just free()s the two buffers you just > allocated and returns result, it seems simpler to me to just leave > the code (old 774) unchanged. That is, allocate the buffers after > this check, so that you don't have to worry about free()ing them if > the check fails. This isn't a big deal, though. > Ok, then I will keep the code as it is. > 1302: Shouldn't you assert() that this doesn't fail with _TRUNCATED > since you know that dst is much shorter than PATH_MAX? > I can add that. > 1317: What happens if this fails? > fail the operation. > lib/libscf/inc/libscf_priv.h > 315-20: Please move these up with the other #defines. > Done. > lib/libscf/common/lowlevel.c > 6870: > - DOOR_ERRORS_BLOCK() will also return _INTERNAL if make_door_call() > fails with RESULT_TOO_BIG. > Added. > - What do you mean by "strlcpy error"? > Should be removed as result of code update. > 6874: According to the comment before repository_switch() in client.c, > this request can also fail with _BACKEND_ACCESS and _NO_RESOURCES. > Added. > cmd/svc/svcadm/svcadm.c > 2412: Since this is a usage problem, you should exit(UU_EXIT_USAGE). > Done. > David >
