Steve Peng writes: > > A new full webrev has been posted under > > http://cr.opensolaris.org/~stevep/6351623 (6351623 Initial > manifest-import is slow) > > This webrev includes all changes for the feedback I have received. All > necessary tests had been run succesfully including the 'svcadm > _smf_repository_switch' stress test that Dan suggested on the > global/non-global zone environment. > > Please take a look at and send me any comment. If this round of code > review runs smoothly then the plan is to putback this > performance improvement into build 84. > > > TIA - Steve [SNIP]
Hi Steve, I have just 2 minor comments. Neither of these require a new weberv. tom usr/src/cmd/svc/milestone/manifest-import: line 474: s/fails/failed/ usr/src/common/svc/repcache_protocol.h: line 391 I seem to recall that someone suggested that the REPOSITORY_DOOR_VERSION should be incremented, but I could be wrong about that.