Keith M Wesolowski writes: > I'd appreciate review of my changes for > > PSARC 2007/177 SMF read-protected property storage > 6537749 SMF should support read-protection of data > 6538452 svccfg delete leaks memory on syntax error with options > > The webrev may be found at > http://cr.opensolaris.org/~wesolows/6537749/webrev/. Note that this > wad does NOT include any changes for the peripherally related 6546699. > I'll be sending a separate note with my thoughts on that problem. > > Thanks! > > -- > Keith M Wesolowski "Sir, we're surrounded!" > FishWorks "Excellent; we can attack in any direction!" > _______________________________________________ > smf-discuss mailing list > smf-discuss at opensolaris.org
Keith, Except for one small nit, the code looks good to me. The small nit is that svccfg_libscf.c and rc_node.c both use the literal "read_authorization". Perhaps a #define would be appropriate. As for the new audit event that Gary mentioned, it looks to me as if most of the work of generating the event will go into rc_node_property_may_read() in rc_node.c. The event itself will need to be declared in usr/src/lib/libbsm/common/adt.xml and usr/src/lib/libbsm/audit_event.txt. It looks as if you are closer to putback than I am. If that is the case I will make sure that I add the code for the AUE_smf_read_prop event. tom
