On Tue, Aug 07, 2007 at 12:23:51PM -0600, Tom Whitten wrote: > Except for one small nit, the code looks good to me. The small nit is that > svccfg_libscf.c and rc_node.c both use the literal "read_authorization". > Perhaps a #define would be appropriate.
This has been resolved by removing the reference to "read_authorization" in svccfg_libscf.c and instead having it query configd. Thanks for your review. I've posted an updated webrev with a few additional changes if you'd like to review those as well. > As for the new audit event that Gary mentioned, it looks to me as if most > of the work of generating the event will go into > rc_node_property_may_read() in rc_node.c. The event itself will need to be > declared in usr/src/lib/libbsm/common/adt.xml and > usr/src/lib/libbsm/audit_event.txt. > > It looks as if you are closer to putback than I am. If that is the case I > will make sure that I add the code for the AUE_smf_read_prop event. Thanks; keep me posted on this, and let me know if you need anything from me for it. -- Keith M Wesolowski "Sir, we're surrounded!" FishWorks "Excellent; we can attack in any direction!"
