Antonello Cruz writes: > David, > > Please find my answers inline below. I tagged with -- Pending -- the > questions that I think will be better addressed by Tom or Liane. > Thanks for your review and comments. > > Antonello > > David Bustos wrote: > > Quoth Liane Praza on Fri, Aug 22, 2008 at 12:34:53PM -0700: > >> Full webrev and incremental from the 0815 review are here. The old > >> version is preserved at its original location. > >> http://cr.opensolaris.org/~lianep/webrev-20080822/ > >> http://cr.opensolaris.org/~lianep/webrev-20080822-in/ > > > > I wasn't able to finish the rest, but here's what I have before I go on > > vacation. > > > > cmd/svc/dtd/service_bundle.dtd.1 > > 681: Rather than "Identifies a possible property value," I think it > > would be clearer to someone who is first learning about templates to > > say "Describes a legal value for a property," or similar. > > > > 687: Rather than "The literal property value referenced...", I think > > it would be clearer to someone who is first learning about templates > > to say "A string representation of the value," or similar. > > > > 700: Rather than saying, "can take on", I think it would be clearer to > > say something like "... descriptions for legal values of > > a property". Or maybe "allowable" instead of "legal". The point > > being that I think some people would infer from the current language > > that SMF will not allow unmentioned values, whereas it's the service > > implementation which will accept or reject them. > > > > 805: To me, "holds a set of property descriptions" means the elements > > can describe multiple properties. I believe that isn't the case... > > that each prop_pattern describes a single property. If that's > > correct, please adjust the description. > > > > 811: Please note that type may be omitted if required is false. > > > > 831: Similarly to 805 for "holds a set of property group > > descriptions." > -- Pending -- [SNIP]
David, I agree with your comments on cmd/svc/dtd/service_bundle.dtd.1 and I will fix those. I'll leave the rest of the Pendings for Liane. tom
