Liane Praza wrote: > Tom, Antonello, and I would like to invite reviews of the code for > extending the existing SMF templates to incorporate general service > property metadata. > > We previously published and discussed ARC materials on this alias, so > the interfaces and goals of the project shouldn't be much of a surprise. > > I'm re-posting our manpage diffs and interface information here for > reference, though it is not under review: > http://cr.opensolaris.org/~lianep/templates-0815/ > > The code review, parented to the onnv_95 snapshot is here: > http://cr.opensolaris.org/~lianep/webrev-20080815/
I'd like to release an updated webrev, which now includes some fixes for some outstanding bugs we knew about and review comments through this morning. These changes basically address: - svccfg validation ignores instance specific restarters - inetd's templates must be completed - missing quote at end of validate output - libscf validation code should look for re-definition of pgs - Renaud's comments from 08-22 (thanks for the comments, Renaud!) Full webrev and incremental from the 0815 review are here. The old version is preserved at its original location. http://cr.opensolaris.org/~lianep/webrev-20080822/ http://cr.opensolaris.org/~lianep/webrev-20080822-in/ I'm also going to be on vacation through September 3, but please don't delay review comments as Tom and Antonello will still be addressing your comments in my absence. Please make sure to cc the alias or them directly (thomas.whitten at sun.com and antonello.cruz at sun.com). Thanks, and we're looking forward to more reviews! liane
