[smf-discuss] code and output review for svcs -l extension to print method

[Dan Price]

On Wed 19 Sep 2007 at 02:01PM, Liane Praza wrote:
> While procrastinating on a more important task, I've quickly coded up
> the enhancement to svcs -l to print the service methods.  That'd be the
> fix for this bug:
>   http://bugs.opensolaris.org/view_bug.do?bug_id=6532480
> 
> We've talked about this before here:
>   http://www.opensolaris.org/jive/thread.jspa?messageID=99513&#99513
> 
> Code is here.  I'd appreciate feedback by Friday.  It's small.
>   http://cr.opensolaris.org/~lianep/6532480/
> 
> Example output:
...
>   method       start /lib/svc/method/smtp-sendmail start
>   method       stop /lib/svc/method/smtp-sendmail stop %{restarter/contract}
>   method       refresh /lib/svc/method/smtp-sendmail refresh
> 

Output looks good (and very helpful) to me.

print_detailed_method() will leak all three buffers if scf_pg_get_name()
or pg_get_single_val() happen to fail...

Otherwise, code looks fine.

Thanks,

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - dp at eng.sun.com - blogs.sun.com/dp