On Wed 19 Sep 2007 at 03:55PM, Liane Praza wrote: > > > > > print_detailed_method() will leak all three buffers if scf_pg_get_name() > > or pg_get_single_val() happen to fail... > > Nearby code suggested that svcs is a bit erratic about freeing memory. > (Of course, it's designed to be short-running, so careful memory > management is often a matter of taste.) ...
Agreed-- it was the presence of the calls to free() which made me suspect that the code was *trying* to be correct :) > Fixed, and fixed the code it was inspired by. Respun: > http://cr.opensolaris.org/~lianep/6532480-1/ Looks good to me. -dp -- Daniel Price - Solaris Kernel Engineering - dp at eng.sun.com - blogs.sun.com/dp
