Liane Praza wrote: > Dan Price writes: > >> On Wed 19 Sep 2007 at 02:01PM, Liane Praza wrote: >> >>> While procrastinating on a more important task, I've quickly coded up >>> the enhancement to svcs -l to print the service methods. That'd be the >>> fix for this bug: >>> http://bugs.opensolaris.org/view_bug.do?bug_id=6532480 >>> >>> >> print_detailed_method() will leak all three buffers if scf_pg_get_name() >> or pg_get_single_val() happen to fail... >> > > Nearby code suggested that svcs is a bit erratic about freeing memory. > (Of course, it's designed to be short-running, so careful memory > management is often a matter of taste.) > > But, if freeing at all, I should continue to practice good memory > hygiene. > > Fixed, and fixed the code it was inspired by. Respun: > http://cr.opensolaris.org/~lianep/6532480-1/ > Liane,
The respun changes look good to me. The new output is cool. -tony
