Hi meem, Peter Memishian wrote:
> > webrev: http://cr.grommit.com/~zf162725/cr_0308/ > > workspace & cscope: /net/greatwall.prc/workspace/wifi-wpa-cr/usr/src > ^^^^^^^^^ >The above seems incorrect -- seems like it should be "workspaces". > > Sorry, you are right. >I've only looked at the (handful of) kernel changes and scanned the DLPI >changes. > > Thanks, I will look at it soon. -- Quaker >uts/common/sys/ethernet.h: > > * 97-99: Please merge these constants in with the rest of the > ETHERTYPE_* values. (They're all sorted in numeric order.) > >cmd/cmd-inet/usr.lib/wpad/l2_packet.c: > > * 53: Comment says that DL_PROMISC_PHYS needs to be enabled, but > the code doesn't do that. (But why would DL_PROMISC_PHYS be > needed? Is the comment just wrong?) > > * 106: This will massively over-allocate: > > uint64_t buf[IEEE80211_MTU_MAX]; /* aligned on 64-bit boundary */ > > You need: > > uint64_t buf[IEEE80211_MTU_MAX / sizeof (uint64_t)]; > > >
