Hi Sebastian, Sebastian Haas wrote: > Wolfgang, > > Wolfgang Grandegger schrieb: >> For the moment I want to keep the old settings. We need to discuss how >> to handle this in a generic way. Either by increasing it to 8, let's >> say, or by providing a kernel config. Other opinions? > 8 would also improve the performance a lot.
Let's await the result of the related discussion. >> I'm still not happy with a few coding issues, e.g.: > >>> + struct ems_usb *dev = usb_get_intfdata(intf); >>> + struct ems_usb *dev = netdev_priv(netdev); >>> + struct ems_usb *priv = netdev_priv(dev); >>> +static int ems_usb_set_mode(struct net_device *dev, ... >>> +static int ems_usb_start_xmit(struct sk_buff *skb, struct net_device >> *netdev) > >> The inconsistant use of dev, priv and netdev is confusing when you read >> the code. Also the error messages could still be improved. Anyhow, I'm >> going to apply the patch to the SVN trunk as is now. Feel free to >> improve the code quality when you have time. > I'm going to send a small patch which fixes the inconsistent naming. OK, I have a few fixes related to kernel versions as well. > How can we try to get this patch mainline, so the cpc-usb cames out of > staging? Post a patch stack removing the staging driver and adding the new Socket-CAN driver with a CC to all involved MLs, e.g. netdev, Socket-CAN, USB and staging. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
