Marc Kleine-Budde wrote: > Wolfgang Grandegger wrote: >>>> Very nice. Do you really need to stop the NAPI in case of bus-off? You >>>> stopped the device and no more message will come in anyhow. >>> hmmm...I'll try > > works > >> It would be nice if we could get rid of the work queue. For the MSCAN on >> the MPC5200, NAPI is also not disabled on bus-off and the controller >> behaves similar (doing automatic bus-off recovery). > > [..] > >>>>> The driver with NAPI receiving messages with a length of 1 on a 1 Mbit >>>>> link without swapping the messages (tested with pengutronix cansequence). >>>> Please use Vladislavs' canecho_gen/duts at 125kB/sec, which is more >>>> sensitive. Don't forget to fix the unhanded errno ENOBUFS of the write >>>> functions. >>> using select/poll would be better than calling sched_yield >> Well, yes, could this easily be achieved? Oliver? > > Poll/select/... works already even for sending. No work needed.
OK. > BTW: I have a hack that puts sending in blocking mode by default, but > that's a different story. > > Vladislavs test program found a bug, which is fixed and now it works > with all of the three tested bitrates 125K, 250K and 1Mbit. Have you added poll/select support to Vladislav's test programs? If yes, it would be nice if you would post them to the list. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
