On Tue, Oct 06, 2009 at 02:04:16PM +0200, Wolfgang Grandegger wrote: > This patch makes the private functions alloc_can_skb() and > alloc_can_err_skb() of the at91_can driver public and adapts all > drivers to use these. While making the patch I realized, that > the skb's are *not* setup consistently. The skb's are now setup > as shown: [...] > > Please check and comment. > Wolfgang, I think you forgot 1 out of 2 replacements within the sja1000 core. The result I got is a 'skb_over_panic' in the call this skb_put.
I lost the emails on netdev mailing list to reply on Signed-off-by: Kurt Van Dijck <[email protected]> --- kernel/2.6/drivers/net/can/sja1000/sja1000.c | 2 -- 1 file changed, 2 deletions(-) Index: trunk/kernel/2.6/drivers/net/can/sja1000/sja1000.c =================================================================== --- trunk.orig/kernel/2.6/drivers/net/can/sja1000/sja1000.c 2009-10-26 10:10:56.000000000 +0100 +++ trunk/kernel/2.6/drivers/net/can/sja1000/sja1000.c 2009-10-26 10:11:04.000000000 +0100 @@ -333,8 +333,6 @@ if (fi & FI_RTR) id |= CAN_RTR_FLAG; - cf = (struct can_frame *)skb_put(skb, sizeof(struct can_frame)); - memset(cf, 0, sizeof(struct can_frame)); cf->can_id = id; cf->can_dlc = dlc; for (i = 0; i < dlc; i++) _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
