On Mon, Oct 26, 2009 at 11:56:32AM +0100, Wolfgang Grandegger wrote: > Kurt Van Dijck wrote: > > On Tue, Oct 06, 2009 at 02:04:16PM +0200, Wolfgang Grandegger wrote: > >> This patch makes the private functions alloc_can_skb() and > >> alloc_can_err_skb() of the at91_can driver public and adapts all > >> drivers to use these. While making the patch I realized, that > >> the skb's are *not* setup consistently. The skb's are now setup > >> as shown: > > [...] > >> Please check and comment. > >> > > Wolfgang, I think you forgot 1 out of 2 replacements within > > the sja1000 core. > > The result I got is a 'skb_over_panic' in the call this skb_put. > > Oops, thank for pointing that out. Applied to and fixed on SVN trunk. > > > I lost the emails on netdev mailing list to reply on > > It would be nice if you could post a corresponding patch to the netdev > mailing list as well. small question. which is the git repository that I'll base the patch on? I'm not yet so familiar with it :-).
Kurt _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
