Attached is a patch that I think addresses the hash_value_t for msvc 64 without breaking anything else, for your review. The first ifdef may need to be changed to #if _MSC_VER >= 1400 depending on how VC 6 and/or mingw behaves on that block of code, unfortunately I don't have those to test against. Also, please let me know how you would like to proceed on the other part of the patch for addressing the other 64bit issues. On closer review, we may want to have some typedefs similar to this block and use that for the casting on the pointer math that I replaced with size_t in the previous patch.
Mike > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:sofia-sip- > [EMAIL PROTECTED] On Behalf Of Pekka Pessi > Sent: Wednesday, August 30, 2006 3:42 AM > To: [email protected] > Subject: Re: [Sofia-sip-devel] MSVC detected 64 bit issues. > > On 8/29/06, Kai Vehmanen <[EMAIL PROTECTED]> wrote: > > So any good ideas how to fix this cleanly? Obviously casting to int will > > remove the warnings but not cure the problem. > > > > The options are: > > 1) turn ints into size_t's (but no in any public interfaces) > > 2) truncate size_t to INT_MAX and then cast to (int) > > 3) cast to ints like in Mike's patch > > 4) do nothing > > I'd go for 2). Of course, the allocations based on such results should > be carefully checked as explained. > > There already are a few limitations on su_*alloc() functions, they do > not support memory blocks larger than 2 GB. I think there are similar > problems with message parser. The http_off_t is a half-hearted attempt > to siolve some of the problems, however, it is defined as unsigned > long (and not as uint64_t, for instance). > > -- > Pekka.Pessi mail at nokia.com > > ------------------------------------------------------------------------ - > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Sofia-sip-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/sofia-sip-devel
msvc64_hashtable.patch
Description: msvc64_hashtable.patch
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Sofia-sip-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sofia-sip-devel
