Hi, On Thu, 31 Aug 2006, Michael Jerris wrote:
> Attached is a patch that I think addresses the hash_value_t for msvc 64 > without breaking anything else, for your review. The first ifdef may > need to be changed to #if _MSC_VER >= 1400 depending on how VC 6 and/or > mingw behaves on that block of code, unfortunately I don't have those to > test against. Also, please let me know how you would like to proceed on seems good to me (Mike explained on #sofia-sip that __w64 is not a type modifier but just a hint to compiler). I'll test this later with VC6. Pekka, ...? I'm just thinking what the users of the hash table are really expecting (and should expect) from the value type -- should we add some asserts just in case? > the other part of the patch for addressing the other 64bit issues. On > closer review, we may want to have some typedefs similar to this block > and use that for the casting on the pointer math that I replaced with > size_t in the previous patch. For pointers, we might prefer to explicitly use intptr_t or uintptr_t. They are guaranteed to hold any 'void*'. -- under work: Sofia-SIP at http://sofia-sip.sf.net ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Sofia-sip-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sofia-sip-devel
