[
https://issues.apache.org/jira/browse/SOLR-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558434#action_12558434
]
Doug Daniels commented on SOLR-356:
-----------------------------------
I agree that the ValueSourceParser should be isolated from the low-level
details like grabbing commas between args.
I thought about the first option you suggested, and it seems difficult with
recursive functions. When the ValueSourceParser.createValueSource method
expects another ValueSource as an arg, it would need to invoke whatever code
created it (presumably from the FunctionQParser). Alternately, the
FunctionQParser could ensure that the innermost functions are run first,
passing their completed values out to enclosing functions as params.
It seems simpler to me to go with the second option though -- locking down the
API on FunctionQParser. The ValueSourceParser would already have access to
FunctionQParser, which it could call when it needs to parse a ValueSource
argument.
What do you think?
> pluggable functions (value sources)
> -----------------------------------
>
> Key: SOLR-356
> URL: https://issues.apache.org/jira/browse/SOLR-356
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Attachments: pluggableFunctions.patch
>
>
> allow configuration of new value sources ot be created by the function query
> parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
