[ 
https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695765#action_12695765
 ] 

Shalin Shekhar Mangar commented on SOLR-940:
--------------------------------------------

Thanks Uwe!

I'm having trouble applying the patch:
{code}
shalinsman...@shalinsmangar-laptop:~/work/oss/solr-trunk$ patch --dry-run -p0 < 
/home/shalinsmangar/Desktop/SOLR-940-newTrieAPI.patch 
(Stripping trailing CRs from patch.)
patching file example/solr/conf/schema.xml
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/solr/analysis/TrieIndexTokenizerFactory.java
Hunk #3 FAILED at 51.
1 out of 3 hunks FAILED -- saving rejects to file 
src/java/org/apache/solr/analysis/TrieIndexTokenizerFactory.java.rej
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/solr/analysis/TrieQueryTokenizerFactory.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/solr/schema/TrieField.java
{code}

No biggie, I'll take care of it.

bq. I forget to mention: with LUCENE-1582 and this patch, sorting now works for 
trie fields.
That is great news!

bq. About function queries: If they use the "normal" field cache (long, int, 
double, float) with the supplied trie parser
The function query stuff does use FieldCache but through the ValueSource 
abstraction. It should be possible by creating a TrieValueSource which uses the 
trie field cache parsers when creating the value source.

bq. By the way, the change needed for compilation with the new Lucene JARs is 
the omitTf thing (SOLR-1079).
Ok, I think we can commit that first as soon as there is consensus on the name.

> TrieRange support
> -----------------
>
>                 Key: SOLR-940
>                 URL: https://issues.apache.org/jira/browse/SOLR-940
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-940-newTrieAPI.patch, SOLR-940-rangequery.patch, 
> SOLR-940-rangequery.patch, SOLR-940-test.patch, SOLR-940.patch, 
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, 
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to