[ 
https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698188#action_12698188
 ] 

Uwe Schindler commented on SOLR-940:
------------------------------------

bq. I'm also not very familiar with that code in QueryComponent but I guess 
that is executed only when field-sort-values are requested (for distributed 
search). I wrote tests for sorting and it works fine! So I think the problem 
will only be during Distributed Search. I'll modify TestDistributedSearch to 
test sorting of trie fields to be sure. If it doesn't, I'll open another issue 
to replace the deprecated ScoreDocComparator with FieldComparator.

OK. If distributed search does not work, the problems are bigger: The problem 
is not the comparator alone, the problem is the FieldCache. The distributed 
search should fill the values into FieldCache and then let the comparator do 
the work. Comparing lucenes code with the solr ones shows, that there are some 
parts of LUCENE-1478 missing. The Comparators use the default parser instead of 
the one given in SortField.getParser() to parse the values (when retrieving 
FieldCache.getInts() & Co).

I am not really sure, why Solr needs to duplicate the sorting code from Lucene? 
Maybe this is no longer needed? In this case, everything would be ok when 
removed.

> TrieRange support
> -----------------
>
>                 Key: SOLR-940
>                 URL: https://issues.apache.org/jira/browse/SOLR-940
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-940-newTrieAPI.patch, SOLR-940-newTrieAPI.patch, 
> SOLR-940-rangequery.patch, SOLR-940-rangequery.patch, SOLR-940-test.patch, 
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, 
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to