[
https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698184#action_12698184
]
Shalin Shekhar Mangar commented on SOLR-940:
--------------------------------------------
{quote}
One note to sorting:
I am not really sure, if sorting works with Solr. The Sortfield returned by
TrieUtils.getSortField contains an own parser (new feature in Lucene 2.9). When
looking through the solr code, searching for SortField in trunk, I noticed,
that QueryComponent has own comparators and FieldCache code (duplicating the
Lucene code), and ignoring the parser given in SortField (the parser is not
passed to FieldCache.getInts() & Co.).
If this is the case, it will simply not work. As I do not know anything about
the internals of Solr and what QueryComponent does, so can you create a
test-case that tests sorting of trie fields?
{quote}
I'm also not very familiar with that code in QueryComponent but I guess that is
executed only when field-sort-values are requested (for distributed search). I
wrote tests for sorting and it works fine! So I think the problem will only be
during Distributed Search. I'll modify TestDistributedSearch to test sorting of
trie fields to be sure. If it doesn't, I'll open another issue to replace the
deprecated ScoreDocComparator with FieldComparator.
{quote}
Updated patch, that supports ValueSource (currently not for Date Trie fields, I
do not know how this should work, the orginal DateField uses a StringIndex as
ValueSource, which is not possible for trie date fields, as no parser available
and if using the standard string index, would fail because of more than one
term/doc). Some tests for function queries are needed (especially as Double and
FloatParser are not tested by Lucene at the moment), maybe change a test for
conventional XxxFields to do the same test with a trie field.
{quote}
I'll write tests for these as well. But trie date is just a trie long field so
we should be able to use a LongFieldSource for this, right?
> TrieRange support
> -----------------
>
> Key: SOLR-940
> URL: https://issues.apache.org/jira/browse/SOLR-940
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-940-newTrieAPI.patch, SOLR-940-newTrieAPI.patch,
> SOLR-940-rangequery.patch, SOLR-940-rangequery.patch, SOLR-940-test.patch,
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch,
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
