Hi, Thank you for reviewing this change!
* Sergey Bylokhov <sergey.bylok...@oracle.com> [2015-10-09 07:44]: > I do not see a problem to integrate such changes, Great! If the idea sounds sensible, I would be happy to tweak the implementation based on your suggestions. > since I assume you will > plan to backport it to jdk8. Indeed. I hope to backport this all the way to OpenJDK 7. > But later in jdk9 however probably it will be > better to move such information to the configuration file > JAVA_HOME/conf/sound.properties Sure, that makes sense. Someone else had suggested making this information tweakable and using the sound.properties file for this makes a lot of sense. I suppose we couldn't do this with 8, though, since the list of supported keys in this file is frozen for 8? > I have one note about the fix: the usage of libaudio.exists() vs > defaultSoundFont.isFile(). I think we should use the same call in all cases, > the question is which one. Also it is interesting should we check that the > file is readable. I don't have a strong opinion here. isFile() is basically a superset of exists() and prevents us from trying to open a directory accidentally. In general, I think it makes sense to be more defensive. Shall I add them to this patch? Or shall I make minimal adjustments and post a separate patch to make this more defensive? Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
