On 09.10.15 18:26, Omair Majid wrote:
But later in jdk9 however probably it will be
better to move such information to the configuration file
JAVA_HOME/conf/sound.properties
Sure, that makes sense. Someone else had suggested making this
information tweakable and using the sound.properties file for this makes
a lot of sense. I suppose we couldn't do this with 8, though, since the
list of supported keys in this file is frozen for 8?
I suggest to make such change as a separate fix.
I don't have a strong opinion here. isFile() is basically a superset of
exists() and prevents us from trying to open a directory accidentally.
In general, I think it makes sense to be more defensive. Shall I add
them to this patch? Or shall I make minimal adjustments and post a
separate patch to make this more defensive?
I do not see a reason why we should not use isFile() in all cases.
--
Best regards, Sergey.
