On 26.10.15 21:51, Omair Majid wrote:
Sure, that makes sense. Someone else had suggested making this
information tweakable and using the sound.properties file for this makes
a lot of sense. I suppose we couldn't do this with 8, though, since the
list of supported keys in this file is frozen for 8?
I suggest to make such change as a separate fix.
Does the original patch look okay, then? Shall I go ahead and commit it
as is and then post separate patches to fix other things?
Besides the "sound.properties" I also suggested to investigate the usage
of exists/isFile. The whole getDefaultSoundbank() should use the one
method. If you sure that isFile() is better then change all other usage,
if you unsure then use exists() in the new code.
My assumption that isFile() should be better choice.
Thanks,
Omair
--
Best regards, Sergey.
