On Friday 26 June 2009 01:57:35 YAMAMOTO Takashi wrote: > > On Wednesday 10 June 2009 23:23:15 YAMAMOTO Takashi wrote: > >> Module Name: src > >> Committed By: yamt > >> Date: Wed Jun 10 22:23:15 UTC 2009 > >> > >> Modified Files: > >> src/sys/kern: vfs_lockf.c > >> > >> Log Message: > >> lf_split: cv_destroy a condvar before clobbering it. > > > > I don't think this is correct. The CV isn't being clobbered, it's just > > part of a struct that's being copied and needs to be cv_init'ed due to > > the copying. > > > > Nick > > i don't understand what you mean. > "clobber" is not a correct word to describe "overwrite with memcpy", you > mean? > > YAMAMOTO Takashi
Nevermind, I guess sparelock CV should be destroyed. I misremembered what was happening here. Nick