On Tue Jul 14 2009 at 20:59:00 +0000, Alan Barrett wrote: > Module Name: src > Committed By: apb > Date: Tue Jul 14 20:59:00 UTC 2009 > > Modified Files: > src/sys/kern: vfs_wapbl.c > > Log Message: > Convert free text inside #ifdef to a proper comment. > Inspired by PR 41255 from Kurt Lidl.
That was on purpose to make sure it did NOT compile and accidentally get used. At least add an #error. Better yet, kill the whole #ifdef hell_froze_over block. > Modified files: > > Index: src/sys/kern/vfs_wapbl.c > diff -u src/sys/kern/vfs_wapbl.c:1.25 src/sys/kern/vfs_wapbl.c:1.26 > --- src/sys/kern/vfs_wapbl.c:1.25 Sun Apr 5 11:48:02 2009 > +++ src/sys/kern/vfs_wapbl.c Tue Jul 14 20:59:00 2009 > @@ -1,4 +1,4 @@ > -/* $NetBSD: vfs_wapbl.c,v 1.25 2009/04/05 11:48:02 lukem Exp $ */ > +/* $NetBSD: vfs_wapbl.c,v 1.26 2009/07/14 20:59:00 apb Exp $ */ > > /*- > * Copyright (c) 2003, 2008, 2009 The NetBSD Foundation, Inc. > @@ -36,7 +36,7 @@ > #define WAPBL_INTERNAL > > #include <sys/cdefs.h> > -__KERNEL_RCSID(0, "$NetBSD: vfs_wapbl.c,v 1.25 2009/04/05 11:48:02 lukem Exp > $"); > +__KERNEL_RCSID(0, "$NetBSD: vfs_wapbl.c,v 1.26 2009/07/14 20:59:00 apb Exp > $"); > > #include <sys/param.h> > > @@ -1175,10 +1175,12 @@ > > if (bp->b_error) { > #ifdef notyet /* Can't currently handle possible dirty buffer reuse */ > - XXXpooka: interfaces not fully updated > - Note: this was not enabled in the original patch > - against netbsd4 either. I don't know if comment > - above is true or not. > + /* > + * XXXpooka: interfaces not fully updated > + * Note: this was not enabled in the original patch > + * against netbsd4 either. I don't know if comment > + * above is true or not. > + */ > > /* > * If an error occurs, report the error and leave the >