Module Name: src
Committed By: jmcneill
Date: Mon Dec 14 11:16:33 UTC 2020
Modified Files:
src/sys/arch/aarch64/aarch64: bus_space.c
Log Message:
The bus_space(9) man page is not clear whether barriers should enforce
ordering or completion. To be safe, use dsb here instead of dmb.
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/arch/aarch64/aarch64/bus_space.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/aarch64/aarch64/bus_space.c
diff -u src/sys/arch/aarch64/aarch64/bus_space.c:1.11 src/sys/arch/aarch64/aarch64/bus_space.c:1.12
--- src/sys/arch/aarch64/aarch64/bus_space.c:1.11 Thu Oct 15 21:14:15 2020
+++ src/sys/arch/aarch64/aarch64/bus_space.c Mon Dec 14 11:16:33 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: bus_space.c,v 1.11 2020/10/15 21:14:15 jmcneill Exp $ */
+/* $NetBSD: bus_space.c,v 1.12 2020/12/14 11:16:33 jmcneill Exp $ */
/*
* Copyright (c) 2017 Ryo Shimizu <r...@nerv.org>
@@ -27,7 +27,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(1, "$NetBSD: bus_space.c,v 1.11 2020/10/15 21:14:15 jmcneill Exp $");
+__KERNEL_RCSID(1, "$NetBSD: bus_space.c,v 1.12 2020/12/14 11:16:33 jmcneill Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -615,13 +615,13 @@ generic_bs_barrier(void *t, bus_space_ha
switch (flags) {
case BUS_SPACE_BARRIER_READ:
- dmb(ishld);
+ dsb(ishld);
break;
case BUS_SPACE_BARRIER_WRITE:
- dmb(ishst);
+ dsb(ishst);
break;
case BUS_SPACE_BARRIER_READ|BUS_SPACE_BARRIER_WRITE:
- dmb(ish);
+ dsb(ish);
break;
}
}
