On 05/10/15(Mon) 09:39, Masao Uebayashi wrote: > CVSROOT: /cvs > Module name: src > Changes by: uebay...@cvs.openbsd.org 2015/10/05 09:39:01 > > Modified files: > sys/net : if.c > > Log message: > Accumulate ifq_drops into if_oqdrops if if_start(). > > mpi@ questioned usefulness of if_snd.ifq_drops, but this is what exists now. > This area is going to be readily polished.
Will it really be polished? To do what? By whom? Where is the diff? My experience is that people tend to drop diff in the tree and I then *I* have to deal with this because I need to move forward with other stuff. I already spent weeks on issues like that, I'm sorry but I don't want to do that anymore. I did not ok your diff in the first place because if_start() is not the correct place for such counter. We are slowly moving per-driver counters and bpf bits to if_enqueue() so your dirty hack will have to be rewritten. Plus it doesn't work for the places in the stack where ifp->if_start() is called directly. So the way I see it is that you fix your problem and you give me one more. As if I didn't have enough problems to deal with right now.
